implement feedback loop

This commit is contained in:
2026-03-07 16:15:21 +01:00
parent 5d57abe913
commit 3de787e07c
18 changed files with 170 additions and 12 deletions

View File

@@ -1,3 +1,6 @@
namespace AipsCore.Application.Abstract.MessageBroking;
public interface IMessage;
public interface IMessage
{
Guid? GetWhiteboardId();
};

View File

@@ -3,4 +3,10 @@ using AipsCore.Application.Models.Shape.Command.CreateArrow;
namespace AipsCore.Application.Common.Message.AddArrow;
public record AddArrowMessage(CreateArrowCommand Command) : IMessage;
public record AddArrowMessage(CreateArrowCommand Command) : IMessage
{
public Guid? GetWhiteboardId()
{
return Guid.Parse(Command.WhiteboardId);
}
}

View File

@@ -3,4 +3,10 @@ using AipsCore.Application.Models.Shape.Command.CreateLine;
namespace AipsCore.Application.Common.Message.AddLine;
public record AddLineMessage(CreateLineCommand Command) : IMessage;
public record AddLineMessage(CreateLineCommand Command) : IMessage
{
public Guid? GetWhiteboardId()
{
return Guid.Parse(Command.WhiteboardId);
}
}

View File

@@ -3,4 +3,10 @@ using AipsCore.Application.Models.Shape.Command.CreateRectangle;
namespace AipsCore.Application.Common.Message.AddRectangle;
public record AddRectangleMessage(CreateRectangleCommand Command) : IMessage;
public record AddRectangleMessage(CreateRectangleCommand Command) : IMessage
{
public Guid? GetWhiteboardId()
{
return Guid.Parse(Command.WhiteboardId);
}
}

View File

@@ -3,4 +3,10 @@ using AipsCore.Application.Models.Shape.Command.CreateTextShape;
namespace AipsCore.Application.Common.Message.AddTextShape;
public record AddTextShapeMessage(CreateTextShapeCommand Command) : IMessage;
public record AddTextShapeMessage(CreateTextShapeCommand Command) : IMessage
{
public Guid? GetWhiteboardId()
{
return Guid.Parse(Command.WhiteboardId);
}
}

View File

@@ -0,0 +1,12 @@
using AipsCore.Application.Abstract.MessageBroking;
using AipsCore.Domain.Common.Validation;
namespace AipsCore.Application.Common.Message.ErrorMessage;
public record ErrorMessage(Guid WhiteboardId, ICollection<ValidationError> Errors) : IMessage
{
public Guid? GetWhiteboardId()
{
return WhiteboardId;
}
}

View File

@@ -0,0 +1,18 @@
using AipsCore.Application.Abstract.MessageBroking;
namespace AipsCore.Application.Common.Message.ErrorMessage;
public class ErrorMessageHandler : IMessageHandler<ErrorMessage>
{
private readonly IErrorMessageHandleStrategy _handleStrategy;
public ErrorMessageHandler(IErrorMessageHandleStrategy handleStrategy)
{
_handleStrategy = handleStrategy;
}
public async Task Handle(ErrorMessage message, CancellationToken cancellationToken)
{
await _handleStrategy.Handle(message, cancellationToken);
}
}

View File

@@ -0,0 +1,6 @@
namespace AipsCore.Application.Common.Message.ErrorMessage;
public interface IErrorMessageHandleStrategy
{
Task Handle(ErrorMessage message, CancellationToken cancellationToken);
}

View File

@@ -3,4 +3,10 @@ using AipsCore.Application.Models.Shape.Command.MoveShape;
namespace AipsCore.Application.Common.Message.MoveShape;
public record MoveShapeMessage(MoveShapeCommand Command) : IMessage;
public record MoveShapeMessage(Guid WhiteboardId, MoveShapeCommand Command) : IMessage
{
public Guid? GetWhiteboardId()
{
return WhiteboardId;
}
}

View File

@@ -2,4 +2,10 @@ using AipsCore.Application.Abstract.MessageBroking;
namespace AipsCore.Application.Common.Message.TestMessage;
public record TestMessage(string Text) : IMessage;
public record TestMessage(string Text) : IMessage
{
public Guid? GetWhiteboardId()
{
return null;
}
}

View File

@@ -127,6 +127,6 @@ public class WhiteboardHub : Hub
{
await MoveShape(moveShape);
await _messagingService.MoveShape(moveShape);
await _messagingService.MoveShape(CurrentWhiteboard.WhiteboardId, moveShape);
}
}

View File

@@ -32,6 +32,18 @@ public class WhiteboardManager
_whiteboards.TryRemove(whiteboardId, out _);
}
public async Task RefreshWhiteboard(Guid whiteboardId)
{
var whiteboard = GetWhiteboard(whiteboardId);
if (whiteboard == null)
{
RemoveWhiteboard(whiteboardId);
}
await AddWhiteboard(whiteboardId);
}
public Whiteboard? GetWhiteboard(Guid whiteboardId)
{
return _whiteboards.GetValueOrDefault(whiteboardId);

View File

@@ -1,3 +1,4 @@
using AipsCore.Application.Common.Message.ErrorMessage;
using AipsCore.Infrastructure.DI;
using AipsRT.Hubs;
using AipsRT.Model.Whiteboard;
@@ -15,6 +16,10 @@ builder.Configuration.AddEnvironmentVariables();
builder.Services.AddSignalR();
builder.Services.AddAips(builder.Configuration);
builder.Services.AddAipsMessageHandlers();
builder.Services.AddSingleton<IErrorMessageHandleStrategy, RtErrorHandleStrategy>();
builder.Services.AddHostedService<ErrorSubscriberBackgroundService>();
builder.Services.AddScoped<GetWhiteboardService>();
builder.Services.AddSingleton<WhiteboardManager>();

View File

@@ -0,0 +1,25 @@
using AipsCore.Application.Abstract;
using AipsCore.Application.Abstract.MessageBroking;
using AipsCore.Application.Common.Message.ErrorMessage;
namespace AipsRT.Services;
public class ErrorSubscriberBackgroundService : BackgroundService
{
private readonly IMessageSubscriber _subscriber;
private readonly IDispatcher _dispatcher;
public ErrorSubscriberBackgroundService(IMessageSubscriber subscriber, IDispatcher dispatcher)
{
_subscriber = subscriber;
_dispatcher = dispatcher;
}
protected override async Task ExecuteAsync(CancellationToken stoppingToken)
{
await _subscriber.SubscribeAsync<ErrorMessage>(async (errorMessage, ct) =>
{
await _dispatcher.Execute(errorMessage, ct);
});
}
}

View File

@@ -11,5 +11,5 @@ public interface IMessagingService
Task CreateLine(Guid whiteboardId, Line line);
Task CreateTextShape(Guid whiteboardId, TextShape textShape);
Task MoveShape(MoveShapeCommand moveShape);
Task MoveShape(Guid whiteboardId, MoveShapeCommand moveShape);
}

View File

@@ -95,9 +95,9 @@ public class MessagingService : IMessagingService
await _messagePublisher.PublishAsync(message);
}
public async Task MoveShape(MoveShapeCommand moveShape)
public async Task MoveShape(Guid whiteboardId, MoveShapeCommand moveShape)
{
var message = new MoveShapeMessage(moveShape);
var message = new MoveShapeMessage(whiteboardId, moveShape);
await _messagePublisher.PublishAsync(message);
}
}

View File

@@ -0,0 +1,29 @@
using AipsCore.Application.Common.Message.ErrorMessage;
using AipsRT.Hubs;
using AipsRT.Model.Whiteboard;
using Microsoft.AspNetCore.SignalR;
namespace AipsRT.Services;
public class RtErrorHandleStrategy : IErrorMessageHandleStrategy
{
private readonly IHubContext<WhiteboardHub> _hubContext;
private readonly WhiteboardManager _whiteboardManager;
public RtErrorHandleStrategy(IHubContext<WhiteboardHub> hubContext, WhiteboardManager whiteboardManager)
{
_hubContext = hubContext;
_whiteboardManager = whiteboardManager;
}
public async Task Handle(ErrorMessage message, CancellationToken cancellationToken)
{
await _whiteboardManager.RefreshWhiteboard(message.WhiteboardId);
var whiteboard = _whiteboardManager.GetWhiteboard(message.WhiteboardId)!;
await _hubContext.Clients
.Group(whiteboard.WhiteboardId.ToString())
.SendAsync("InitWhiteboard", whiteboard, cancellationToken);
}
}

View File

@@ -1,6 +1,7 @@
using System.Reflection;
using AipsCore.Application.Abstract;
using AipsCore.Application.Abstract.MessageBroking;
using AipsCore.Application.Common.Message.ErrorMessage;
using AipsCore.Application.Common.Message.TestMessage;
using AipsCore.Domain.Common.Validation;
using AipsWorker.Utilities;
@@ -12,12 +13,14 @@ public class WorkerService : BackgroundService
{
private readonly IDispatcher _dispatcher;
private readonly IMessageTypesProvider _messageTypesProvider;
private readonly IMessagePublisher _publisher;
private readonly SubscribeMethodUtility _subscribeMethodUtility;
public WorkerService(IMessageSubscriber subscriber, IDispatcher dispatcher, IMessageTypesProvider messageTypesProvider)
public WorkerService(IMessageSubscriber subscriber, IDispatcher dispatcher, IMessageTypesProvider messageTypesProvider, IMessagePublisher publisher)
{
_dispatcher = dispatcher;
_messageTypesProvider = messageTypesProvider;
_publisher = publisher;
_subscribeMethodUtility = new SubscribeMethodUtility(subscriber);
}
@@ -45,6 +48,15 @@ public class WorkerService : BackgroundService
}
catch (ValidationException validationException)
{
var whiteboardId = message.GetWhiteboardId();
if (whiteboardId is not null)
{
var errorMessage = new ErrorMessage(whiteboardId.Value, validationException.ValidationErrors);
await _publisher.PublishAsync(errorMessage, ct);
}
Console.WriteLine("===Validation Exception: ");
foreach (var error in validationException.ValidationErrors)
{